Good job, man! It can be very satisfying to fix even simple things, right?
Vince
I used to use vinegar to clean old coins very many years ago. The old British penny came up like new after soaking in vinegar, so I thought it would work on this switch. Since the switch did not work at all, I thought I had nothing to lose by trying to repair it. I expected the terminals to be corroded, but not as badly as they were.
It may be possible to clean the terminals without dismantling the switch, as the vinegar would probably get to all the corroded parts without pulling the switch apart. If it corroded, it would be exposed to air and moisture, so the vinegar could get to those parts and reverse the corrosion.
I had the same corrosion problem on the terminal part of the ignition switch. I pulled it apart, cleaned it, put it back together again, it worked for a short while and then fell apart. Luckily Rimmer Bros, Triumph specialists, had the right part, and the rubber shroud it comes with holds the terminal block to the key part very well.
Tracing many electrical faults, I have found that the faults are caused by either 1) corrosion in the motor or bulb holder, 2) faulty bulbs, 3) faulty earth, or 4) surprisingly, when putting in new wiring looms, there are parts where there is no earth at all, so I have had to run separate earth wires. The window motor earth wire only connects to the door interior light earth switch and the metal bracket holding the door switch and the ends of the dashboard. So that earth does not link to the chassis. I had to run a wire from the metal dash end bracket to the metal dash central bracket which is bolted to the chassis just north of the gear lever.
You have to be in the right mood to trace electrical faults. I have had 12v showing at the electrical part, (right side headlight) and it still not working. I changed the blue/red wire for another, and it worked perfectly. I cannot explain why the first wire did not get the bulb working with 12v showing, but a simple wire change got it to work.
I have no idea how the horn earths through the steering column switch. It seems to be connected to a main beam wire. Another mystery.
When tracing faults on the indicators, unless the correct wattage bulbs are all connected and working, the indicators will not flash. They need the proper load to make the bi-metallic strip heat up and go off or they just stay permanently on with too low a load.